himanshukandwal commented on code in PR #2588:
URL: https://github.com/apache/helix/pull/2588#discussion_r1293928702
##########
helix-common/src/main/java/org/apache/helix/constants/InstanceConstants.java:
##########
@@ -8,4 +8,12 @@ public enum InstanceDisabledType {
USER_OPERATION,
DEFAULT_INSTANCE_DISABLE_TYPE
}
+
+ public enum InstanceOperation {
+ EVACUATE,
+ SWAP_IN,
+ SWAP_OUT,
+ ENABLE,
Review Comment:
Just curious, do you think this might create confusion with Instance config
HELIX_ENABLED.
I remember you mentioned SWAPED_IN, this transitioning to
`instanceConfig.setInstanceEnabled` also looks good.
`Enable` is quite common term and maybe this way, from the name itself its
clear that which state lifecycle we are talking about.
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java:
##########
@@ -374,6 +374,44 @@ public void enableInstance(String clusterName,
List<String> instances, boolean e
//enableInstance(clusterName, instances, enabled, null, null);
}
+ @Override
+ // TODO: Name may change in future
+ public void setInstanceOperation(String clusterName, String instanceName,
+ InstanceConstants.InstanceOperation instanceOperation) {
+
+
Review Comment:
nit: extra lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
