xyuanlu commented on code in PR #2588:
URL: https://github.com/apache/helix/pull/2588#discussion_r1295143027
##########
helix-common/src/main/java/org/apache/helix/constants/InstanceConstants.java:
##########
@@ -8,4 +8,12 @@ public enum InstanceDisabledType {
USER_OPERATION,
DEFAULT_INSTANCE_DISABLE_TYPE
}
+
+ public enum InstanceOperation {
+ EVACUATE,
+ SWAP_IN,
+ SWAP_OUT,
+ ENABLE,
+ DISABLE;
Review Comment:
Had an offline discussion. We will keep `enable` and `disable` for backward
compatibility. When user set HELIX_ENABLED from false to true, we will set
OPERATION to be `enabled` if the field is non empty and vice vesa.
##########
helix-common/src/main/java/org/apache/helix/constants/InstanceConstants.java:
##########
@@ -8,4 +8,12 @@ public enum InstanceDisabledType {
USER_OPERATION,
DEFAULT_INSTANCE_DISABLE_TYPE
}
+
+ public enum InstanceOperation {
+ EVACUATE,
+ SWAP_IN,
+ SWAP_OUT,
+ ENABLE,
+ DISABLE;
Review Comment:
Had an offline discussion. We will keep `enable` and `disable` for backward
compatibility. When user set HELIX_ENABLED from false to true, we will set
OPERATION to be `enabled` if the field is non empty and vice versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
