himanshukandwal commented on code in PR #2603:
URL: https://github.com/apache/helix/pull/2603#discussion_r1302269166
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -494,6 +494,9 @@ private void
reportTopStateComesBack(ResourceControllerDataProvider cache, Map<S
// In case of recovery after failure, we should decrement the
missingTopStateBeyondThresholdGauge value.
if (clusterStatusMonitor != null && record.isFailed()) {
+ LogUtil.logInfo(LOG, _eventId, String.format(
+ "Missing top state recovered for resource %s and partition %s.
Decrementing missingTopStateBeyondThresholdGauge.",
+ resourceName, partition.getPartitionName()));
Review Comment:
This wont be published all the time, and will be published only when the
threshold is missed (and the record is set to failed).
We are publishing similar log during increment as well, to ensure that
metric is emitted, given this is a very critical metric for end-users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
