rahulrane50 commented on code in PR #2603:
URL: https://github.com/apache/helix/pull/2603#discussion_r1302299990
##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java:
##########
@@ -480,7 +480,6 @@ public long getRebalanceThrottledByErrorPartitionGauge() {
public void resetMaxTopStateHandoffGauge() {
if (_lastResetTime + DEFAULT_RESET_INTERVAL_MS <=
System.currentTimeMillis()) {
_maxSinglePartitionTopStateHandoffDuration.updateValue(0L);
- _missingTopStatePartitionsBeyondThresholdGauge.updateValue(0L);
Review Comment:
Had a offline discussion. Let's check about what happens if cache gets
dropped as a part of another pipeline (periodic rebalance etc) before we remove
this reset part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
