xyuanlu commented on code in PR #2612:
URL: https://github.com/apache/helix/pull/2612#discussion_r1322092359


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/factory/ZkMetaClientFactory.java:
##########
@@ -36,4 +38,17 @@ public MetaClientInterface getMetaClient(MetaClientConfig 
config) {
     }
     throw new IllegalArgumentException("Invalid MetaClientConfig type.");
   }
+
+  @Override
+  public MetaClientCacheInterface getMetaClientCache(MetaClientConfig config, 
String key, Boolean cacheData,
+                                                     Boolean cacheChildren, 
Boolean lazyCaching) {

Review Comment:
   I was thinking having a cachConfig that has the folling 4 vars.
   String key, Boolean cacheData, Boolean cacheChildren, Boolean lazyCaching



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to