himanshukandwal opened a new pull request, #2617: URL: https://github.com/apache/helix/pull/2617
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: #2616 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In order to improve the code readability and maintenance, we have created following additional classes: * TestExecutionRuntime - contains the Cluster Runtime information. * TestClusterParameters - Parameters used to build the test ZK cluster. * TestExecutionFlow - Dynamics test flow writer, helps in abstracting the repeated test functions. * TestClusterOperations - Contains static functions to manipulate on the test cluster. * TestClusterValidateOperations - Contains static functions to run validations on the test cluster. With this as just a beginging, there is a lot we can do here to find such as: - Find more of such patterns and enriching TestExecutionFlow to allow standardized & simpler test case writing. - With proper abstraction and encapsulation, we can create a pool of TestZKClusters and parallelize the test case executions (as right now we just create one ZK Server and all tests are run against it) We have simplified `ZKTestBase` class and a simple test has been updated with using the TestExecutionFlow: ```org.apache.helix.integration.TestStandAloneCMSessionExpiry#testStandAloneCMSessionExpiry``` <img width="1614" alt="Screenshot 2023-09-16 at 1 36 48 PM" src="https://github.com/apache/helix/assets/2539436/273cdbf1-a54e-4b1a-bcc1-2b81ce8d96ce";> ### Tests - [x] The following tests are written for this issue: * TestStandAloneCMSessionExpiry#testStandAloneCMSessionExpiry * TestSchemataSM#testSchemataSM - The following is the result of the "mvn test" command on the appropriate module: ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
