gshantanu commented on code in PR #2635:
URL: https://github.com/apache/helix/pull/2635#discussion_r1338078077
##########
helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java:
##########
@@ -113,6 +113,8 @@ public void process(ClusterEvent event) throws Exception {
reportResourcePartitionCapacityMetrics(dataProvider.getAsyncTasksThreadPool(),
clusterStatusMonitor, dataProvider.getResourceConfigMap().values());
+ // TODO: we only need to compute when there are resource using Waged. We
should
+ // do this as perf improvement in future.
Review Comment:
Good callout. If we do this right, and call this only if the cluster has
resources configured to use WAGED, then we should not even need to catch the
exception in the other file (WagedInstanceCapacity). Is there an easy way to
know if any resource is setup to use WAGED?
(This comment doesn't block this PR, asking out of curiosity)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
