xyuanlu commented on code in PR #2635:
URL: https://github.com/apache/helix/pull/2635#discussion_r1338120819
##########
helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java:
##########
@@ -113,6 +113,8 @@ public void process(ClusterEvent event) throws Exception {
reportResourcePartitionCapacityMetrics(dataProvider.getAsyncTasksThreadPool(),
clusterStatusMonitor, dataProvider.getResourceConfigMap().values());
+ // TODO: we only need to compute when there are resource using Waged. We
should
+ // do this as perf improvement in future.
Review Comment:
This is correct. We don't need to compute so no need to catch the exception.
The only way to know is by checking each resource config. We are doing this
anyway in this stage so it shouldn't bring a lot extra cycles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
