GrantPSpencer commented on code in PR #2653:
URL: https://github.com/apache/helix/pull/2653#discussion_r1355519744
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java:
##########
@@ -359,8 +359,10 @@ private void computeWagedAssignmentResult(List<IdealState>
wagedResourceIdealSta
ConfigAccessor cfgAccessor = getConfigAccessor();
List<ResourceConfig> wagedResourceConfigs = new ArrayList<>();
for (IdealState idealState : wagedResourceIdealState) {
- wagedResourceConfigs
- .add(cfgAccessor.getResourceConfig(clusterId,
idealState.getResourceName()));
+ ResourceConfig resourceConfig = cfgAccessor.getResourceConfig(clusterId,
idealState.getResourceName());
Review Comment:
Technically waged rebalance "works" for clusters without resource configs.
This is actually the current set up of our super clusters. Using waged without
any resource configs or relevant instance capacity configs.
I'm not 100% on this part, but I believe if there are no resource configs
then the score calculated for each node will be 0 and tiebreak will go to the
node without any resources assigned to it. I don't think there's a guarantee of
evenness if there's no resource and instance capacity configs, but it will
guarantee that each node will have at least 1 replica assigned to it (given #
replicas > # nodes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
