GrantPSpencer commented on code in PR #2653:
URL: https://github.com/apache/helix/pull/2653#discussion_r1355521390
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java:
##########
@@ -359,8 +359,10 @@ private void computeWagedAssignmentResult(List<IdealState>
wagedResourceIdealSta
ConfigAccessor cfgAccessor = getConfigAccessor();
List<ResourceConfig> wagedResourceConfigs = new ArrayList<>();
for (IdealState idealState : wagedResourceIdealState) {
- wagedResourceConfigs
- .add(cfgAccessor.getResourceConfig(clusterId,
idealState.getResourceName()));
+ ResourceConfig resourceConfig = cfgAccessor.getResourceConfig(clusterId,
idealState.getResourceName());
Review Comment:
The NPE only occurs for the partitionAssignment API, but the actual
controller rebalance algorithm works fine in the same scenario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
