xyuanlu commented on code in PR #2687:
URL: https://github.com/apache/helix/pull/2687#discussion_r1380839712
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java:
##########
@@ -159,13 +159,10 @@ private MaintenanceManagementService(ZKHelixDataAccessor
dataAccessor,
_customRestClient = customRestClient;
_skipZKRead = skipZKRead;
_nonBlockingHealthChecks =
- continueOnFailure ? Collections.singleton(ALL_HEALTH_CHECK_NONBLOCK)
- : Collections.emptySet();
+ nonBlockingHealthChecks == null ? Collections.emptySet() :
nonBlockingHealthChecks;
_skipHealthCheckCategories =
- skipHealthCheckCategories == null ? Collections.emptySet()
- : skipHealthCheckCategories;
- _stoppableHealthCheckList =
- stoppableHealthCheckList == null ? Collections.emptyList()
+ skipHealthCheckCategories == null ? Collections.emptySet() :
skipHealthCheckCategories;
Review Comment:
Please consider to have homogeneous input. For example, we have flack list
for skip customized check and whit list for helix health check. It is a bit
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
