zpinto commented on code in PR #2687:
URL: https://github.com/apache/helix/pull/2687#discussion_r1380837921
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -59,17 +61,21 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static
org.apache.helix.rest.clusterMaintenanceService.MaintenanceManagementService.ALL_HEALTH_CHECK_NONBLOCK;
+
@ClusterAuth
@Path("/clusters/{clusterId}/instances")
public class InstancesAccessor extends AbstractHelixResource {
private final static Logger _logger =
LoggerFactory.getLogger(InstancesAccessor.class);
+
public enum InstancesProperties {
instances,
online,
disabled,
selection_base,
zone_order,
to_be_stopped_instances,
+ stoppable_check_list,
Review Comment:
Call this stoppable_check_list_override is to make it more transparent to
the user that passing a list for this will override the default behavior of
using all checks. If unset, it will use the default.
##########
helix-rest/src/test/java/org/apache/helix/rest/server/AbstractTestClass.java:
##########
@@ -564,6 +564,8 @@ private void
preSetupForParallelInstancesStoppableTest(String clusterName,
clusterConfig.setFaultZoneType("helixZoneId");
clusterConfig.setPersistIntermediateAssignment(true);
_configAccessor.setClusterConfig(clusterName, clusterConfig);
+ RESTConfig emptyRestConfig = new RESTConfig(clusterName);
Review Comment:
Let's not create fake RESTConfig that does not have the required fields.
If causes unexpected behavior on
https://github.com/apache/helix/blob/master/helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java#L459C9-L459C27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
