xyuanlu commented on code in PR #2702:
URL: https://github.com/apache/helix/pull/2702#discussion_r1402589370
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java:
##########
@@ -199,24 +194,11 @@ public IdealState computeNewIdealState(String
resourceName,
finalMapping.getListFields().putAll(userDefinedPreferenceList);
- // 1. Get all SWAP_OUT instances and corresponding SWAP_IN instance pairs
in the cluster.
- Map<String, String> swapOutToSwapInInstancePairs =
- clusterData.getSwapOutToSwapInInstancePairs();
- // 2. Get all enabled and live SWAP_IN instances in the cluster.
- Set<String> enabledLiveSwapInInstances =
clusterData.getEnabledLiveSwapInInstanceNames();
- // 3. For each SWAP_OUT instance in any of the preferenceLists, add the
corresponding SWAP_IN instance to the end.
- // Skipping this when there are not SWAP_IN instances ready(enabled and
live) will reduce computation time when there is not an active
- // swap occurring.
- if (!clusterData.getEnabledLiveSwapInInstanceNames().isEmpty()) {
-
DelayedRebalanceUtil.addSwapInInstanceToPreferenceListsIfSwapOutInstanceExists(finalMapping,
- swapOutToSwapInInstancePairs, enabledLiveSwapInInstances);
- }
-
LOG.debug("currentMapping: {}", currentMapping);
LOG.debug("stateCountMap: {}", stateCountMap);
LOG.debug("liveEnabledNodes: {}", liveEnabledNodes);
Review Comment:
Change name in log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
