zpinto commented on PR #2702: URL: https://github.com/apache/helix/pull/2702#issuecomment-1829363377
Was able to fix TestInstanceAccessor.getAllInstances test. Test failed: testCacheDataUpdates(org.apache.helix.metaclient.impl.zk.TestZkMetaClientCache) https://github.com/apache/helix/issues/2693 which is now fixed by https://github.com/apache/helix/pull/2705 Assuming that review looks good, this PR is ready to be merged. Final Commit Message: Fix WAGED to only use logicalId when computing baseline and centralize picking assignable instances in the cache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
