csudharsanan opened a new pull request, #2792:
URL: https://github.com/apache/helix/pull/2792
### Issues
Fixes #2791
### Description
What: An API endpoint that validates the incoming request and sends a state
transition message to sets one or more partitions from any current state to
ERROR state.
Why: Currently, the participants are unable to set a partition to an ERROR
state explicitly when they seem to be stuck in a specific current state. The
only way a replica can be set to ERROR is from within a state model. Having an
endpoint to allow this behavior would allow the clients to call the
resetPartition endpoint to set it back to INIT state and recover the replica.
resetPartition works only on partitions in error state.
### Tests
```
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Helix 1.3.2-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [
1.504 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [
0.244 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [
0.363 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [
0.380 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [
0.291 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [
0.306 s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [
0.606 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [
0.941 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [
0.228 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [
0.187 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [
0.033 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [
0.205 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [
0.248 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [
0.169 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [
0.246 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [
0.186 s]
[INFO] Apache Helix :: View Aggregator .................... SUCCESS [
0.167 s]
[INFO] Apache Helix :: Meta Client ........................ SUCCESS [
0.146 s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 9.219 s
[INFO] Finished at: 2024-04-16T13:13:02-07:00
[INFO]
------------------------------------------------------------------------
```
- [ ] The following tests are written/updated for this issue:
- TestSetPartitionToErrorState (Integration)
- TestZkHelixAdmin : testSetPartitionToError
- TestPerInstanceAccessor : updateInstance
mvn test -o -Dtest=TestSetPartitionToErrorState -pl=helix-core
AfterClass: TestSetPartitionToErrorState called.
Shut down zookeeper at port 2183 in thread main
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed: 17.697 s - in
org.apache.helix.integration.TestSetPartitionToErrorState
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @
helix-core ---
[INFO] Loading execution data file
/Users/csudhars/Apr15Helix-ForkedHelix/helix/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 806 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 59.426 s
[INFO] Finished at: 2024-04-16T14:14:54-07:00
[INFO]
------------------------------------------------------------------------
mvn test -o -Dtest=TestZkHelixAdmin -pl=helix-core
END testZkHelixAdmin at Tue Apr 16 12:57:29 PDT 2024
AfterClass: TestZkHelixAdmin called.
Shut down zookeeper at port 2183 in thread main
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed: 66.246 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @
helix-core ---
[INFO] Loading execution data file
/Users/csudhars/Apr15Helix-ForkedHelix/helix/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 951 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 02:00 min
[INFO] Finished at: 2024-04-16T12:57:38-07:00
[INFO] -
mvn test -o -Dtest=TestPerInstanceAccessor -pl=helix-rest
[INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed: 219.352 s - in org.apache.helix.rest.server.TestPerInstanceAccessor
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @
helix-rest ---
[INFO] Loading execution data file
/Users/csudhars/Apr15Helix-ForkedHelix/helix/helix-rest/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Restful Interface' with 95
classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 03:52 min
[INFO] Finished at: 2024-04-16T13:03:56-07:00
[INFO] -
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous
assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also
include these changes in merge description so that other developers are aware
of these changes. This allows them to make relevant code changes in feature
branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
