desaikomal commented on code in PR #2792:
URL: https://github.com/apache/helix/pull/2792#discussion_r1591354567
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java:
##########
@@ -1035,6 +1035,135 @@ public ClusterManagementMode
getClusterManagementMode(String clusterName) {
: new ClusterManagementMode(status.getManagementMode(),
status.getManagementModeStatus());
}
+ @Override
+ public void setPartitionsToError(String clusterName, String instanceName,
String resourceName,
+ List<String> partitionNames) {
+ logger.info("Set partitions {} for resource {} on instance {} in cluster
{} to ERROR state.",
+ partitionNames == null ? "NULL" :
HelixUtil.serializeByComma(partitionNames), resourceName,
+ instanceName, clusterName);
+ sendStateTransitionMessage(clusterName, instanceName, resourceName,
partitionNames,
+ Boolean.FALSE);
Review Comment:
reset = false, means error seems a bit wrong. Can we introduce Enum with 3
values - ERROR, RESET, UNDEFINED
Pass ERROR and RESET and process it, for undefined, throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
