xyuanlu commented on code in PR #2834:
URL: https://github.com/apache/helix/pull/2834#discussion_r1681612308


##########
helix-gateway/src/main/proto/HelixGatewayService.proto:
##########
@@ -0,0 +1,52 @@
+syntax = "proto3";
+
+package proto.org.apache.helix.gateway;
+
+message SingleTransitionMessage {
+  enum TransitionType {
+    ADD_SHARD = 0;
+    DELETE_SHARD = 1;
+    CHANGE_ROLE = 2;
+  }
+  string transitionID = 1;    // ID of transition message
+  TransitionType transitionType = 2;   // Transition type for shard operations
+  string resourceID = 3;              // Resource ID
+  string shardID = 4;                 // Shard to perform operation
+  string startState = 5;      // Shard start state
+  string targetState = 6;     // Shard target state.
+}
+
+message StateTransitionMessage{
+  repeated SingleTransitionMessage request = 1;
+}
+
+message SingleReplicaStateTransitionStatus {

Review Comment:
   The outer request is names "replicaState", so I think probably we want to 
keep the replica in name. But we can simplify it as 
"SingleReplicaTransitionStatus"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org

Reply via email to