GrantPSpencer opened a new pull request, #2869: URL: https://github.com/apache/helix/pull/2869
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: https://github.com/apache/helix/issues/2818 testDisableErrorLogByDefault in TestStatusUpdateUtil failing intermittently ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: There are 2 things at play here: 1. TestParticipantManager's static field is setting STATEUPDATEUTIL_ERROR_PERSISTENCY_ENABLED to true. My assumption is that this code is executed early on when the JVM firsts loads these classes. This is why StatusUpdateUtil is pushing error logs to ZK in the first place 2. Setting the static field's variable appears to not successfully propagate the changed value to the loaded class. This is why the logs are pushed to ZK despite using setFinalStatic to change the value to false. At this point I'm not sure why it fails - my very uneducated guess is that the jvm might be doing some optimization by having threads cache the variables and the change is not propagated properly. The observed behavior is that when reading the value of StatusUpdateUtil.ERROR_LOG_TO_ZK_ENABLED within TestStatusUpdateUtil will show false (set by setFinalStatic call), but the value when read within StatusUpdateUtil's publishErrorRecord will show true (original value). I'm not sure this specific approach of having a static method to reassign the static variable is the best practice. Maybe it is better to modify StatusUpdateUtil so that it has a local variable taht can be set by its constructor, or that defaults to the system property value if no value provided. ### Tests - [ ] The following tests are written for this issue: testDisableErrorLogByDefault - The following is the result of the "mvn test" command on the appropriate module: (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
