GrantPSpencer opened a new pull request, #2873: URL: https://github.com/apache/helix/pull/2873
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: https://github.com/apache/helix/issues/2872 When a write occurs, ZkBucketDataAccessor schedules a GC task to execute 60s (default ttl) from when the task was submitted. If there already exists a GC task, [updateGCTimer](https://github.com/apache/helix/blob/2add0c48e648c011740ec419a1b1ef17a5888c97/helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java#L357) attempts to cancel it reschedule it for 60s from then. With this current logic, if the time between subsequent writes is never slower than the ttl (60s), then a GC task will never be executed - the task will constantly be scheduled and then cancelled. ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: ZkBucket GC's are no longer rescheduled if another write occurs. Technically we don't need to track the futures if we don't plan on limiting the size, but with a queue or a stack we can implement logic to limit the # of gc tasks submitted to the thread at any time. ### Tests - [ ] The following tests are written for this issue: testGCScheduler - The following is the result of the "mvn test" command on the appropriate module: (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
