junkaixue commented on code in PR #2873:
URL: https://github.com/apache/helix/pull/2873#discussion_r1710292841
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java:
##########
@@ -429,4 +427,14 @@ private List<String> getPathsToDelete(String path,
List<String> staleVersions) {
staleVersions.forEach(ver -> pathsToDelete.add(path + "/" + ver));
return pathsToDelete;
}
+
+ private String getLastSuccessfulWriteVersion(String path) {
+ byte[] binaryVersionToRead = _zkBaseDataAccessor.get(path + "/" +
LAST_SUCCESSFUL_WRITE_KEY,
+ null, AccessOption.PERSISTENT);
+ if (binaryVersionToRead == null) {
+ throw new ZkNoNodeException(
+ String.format("Last successful write ZNode does not exist for path:
%s", path));
Review Comment:
If we throw exception, the gc thread will be break, right? Shall we just log
it and let it continue? Or we should stop the entire Accessor...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
