frankmu commented on code in PR #2944:
URL: https://github.com/apache/helix/pull/2944#discussion_r1801852644
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java:
##########
@@ -573,11 +575,16 @@ public WagedInstanceCapacity getWagedInstanceCapacity() {
return _wagedInstanceCapacity;
}
- private void buildSimpleCapacityMap(int
globalMaxPartitionAllowedPerInstance) {
+ private void buildSimpleCapacityMap() {
Review Comment:
> If this is here because StickyRebalanceStrategy relies on global node
capacity
Yeah, this is exact the reason - we need to populate the node usage globally
before the rebalance stage. `StatefulRebalancer` seems for rebalancer, but here
we need the rebalance strategy. To me the data provider is the glue for
rebalancer and rebalance strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
