frankmu commented on code in PR #2944:
URL: https://github.com/apache/helix/pull/2944#discussion_r1801854433
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java:
##########
@@ -573,11 +575,16 @@ public WagedInstanceCapacity getWagedInstanceCapacity() {
return _wagedInstanceCapacity;
}
- private void buildSimpleCapacityMap(int
globalMaxPartitionAllowedPerInstance) {
+ private void buildSimpleCapacityMap() {
+ ClusterConfig clusterConfig = getClusterConfig();
+ ClusterTopologyConfig clusterTopologyConfig =
+ ClusterTopologyConfig.createFromClusterConfig(clusterConfig);
+ Map<String, InstanceConfig> instanceConfigMap =
getAssignableInstanceConfigMap();
_simpleCapacitySet = new HashSet<>();
- for (String instance : getEnabledLiveInstances()) {
- CapacityNode capacityNode = new CapacityNode(instance);
- capacityNode.setCapacity(globalMaxPartitionAllowedPerInstance);
+ for (String instanceName : getEnabledLiveInstances()) {
Review Comment:
> This will cause all the replicas on the down or disabled nodes to be
reassigned somewhere else in the cluster if delayed rebalance is being used
If the node is disabled or down, do we expect to re-assign the replica to
other nodes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
