xyuanlu commented on code in PR #2930:
URL: https://github.com/apache/helix/pull/2930#discussion_r1824724609
##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java:
##########
@@ -59,7 +60,7 @@ public class TestZkBucketDataAccessor extends ZkTestBase {
private final ZNRecord record = new ZNRecord(NAME_KEY);
private HelixZkClient _zkClient;
- private BucketDataAccessor _bucketDataAccessor;
+ private ZkBucketDataAccessor _bucketDataAccessor;
Review Comment:
Creating an reference to the base class and pointing to the actual object is
the most common use case. I would suggest let's test that use case in unit
test. If we need to access a particular API, we can do casting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
