jacoblukose commented on code in PR #2930:
URL: https://github.com/apache/helix/pull/2930#discussion_r1827464499


##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java:
##########
@@ -59,7 +60,7 @@ public class TestZkBucketDataAccessor extends ZkTestBase {
   private final ZNRecord record = new ZNRecord(NAME_KEY);
 
   private HelixZkClient _zkClient;
-  private BucketDataAccessor _bucketDataAccessor;
+  private ZkBucketDataAccessor _bucketDataAccessor;

Review Comment:
   @xyuanlu could you help explain whats the actual change to be made here. I 
might not have understood your comment fully. 



##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java:
##########
@@ -59,7 +60,7 @@ public class TestZkBucketDataAccessor extends ZkTestBase {
   private final ZNRecord record = new ZNRecord(NAME_KEY);
 
   private HelixZkClient _zkClient;
-  private BucketDataAccessor _bucketDataAccessor;
+  private ZkBucketDataAccessor _bucketDataAccessor;

Review Comment:
   reverted the change. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to