MarkGaox commented on code in PR #2961:
URL: https://github.com/apache/helix/pull/2961#discussion_r1849626917


##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -285,6 +294,14 @@ private Response batchGetStoppableInstances(String 
clusterId, JsonNode node, boo
         }
       }
 
+      if (selectionBase != InstanceHealthSelectionBase.non_topo_based && 
clusterTopology.getZones()

Review Comment:
   This change may potentially break backward compatibility for users who 
intend to check only a single zone but didn't provide an orderOfZone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to