xyuanlu commented on code in PR #2961:
URL: https://github.com/apache/helix/pull/2961#discussion_r1857322076
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java:
##########
@@ -136,6 +136,40 @@ public ObjectNode
getStoppableInstancesCrossZones(List<String> instances,
return result;
}
+ /**
+ * Evaluates and collects stoppable instances without respecting the zone
order.
+ * The method iterates through instances, performing stoppable checks, and
records reasons for
+ * non-stoppability.
+ *
+ * @param instances A list of instance to be evaluated.
+ * @param toBeStoppedInstances A list of instances presumed to be already
stopped
+ * @return An ObjectNode containing:
+ * - 'stoppableNode': List of instances that can be stopped.
+ * - 'instance_not_stoppable_with_reasons': A map with the instance
name as the key and
+ * a list of reasons for non-stoppability as the value.
+ * @throws IOException
+ */
+ public ObjectNode getStoppableInstancesWithoutTopology(List<String>
instances,
Review Comment:
getStoppableInstancesNonTopologyBased? Or sth similar?
Otherwise it is a bit ambiguous if we are not considering topology, or the
cluster dont have topology configured.
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -82,7 +82,7 @@ public enum InstancesProperties {
}
public enum InstanceHealthSelectionBase {
- instance_based,
+ non_topo_based,
zone_based,
Review Comment:
non_zone_based?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
