MarkGaox opened a new pull request, #2986:
URL: https://github.com/apache/helix/pull/2986

   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the 
PR description:
   #2985
   
   (#200 - Link your issue number here: You can write "Fixes #XXX". Please use 
the proper keyword so that the issue gets closed automatically. See 
https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
   Any of the following keywords can be used: close, closes, closed, fix, 
fixes, fixed, resolve, resolves, resolved)
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI 
changes:
   
   This PR support zone based virtual topology assignment algorithm. In the 
rest service, introduced a configurable parameter enabling users to select the 
desired virtual topology assignment algorithm (e.g.,instance_based or 
zone_based). Additionally, implemented a zone-based assignment algorithm that 
directly maps physical zones to virtual zones.
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   ```
   mvn test 
-Dtest=TestVirtualTopologyGroupService,TestFaultZoneBasedVirtualGroupAssignment,TestClusterService,TestVirtualTopologyGroupAssignment,TestClusterAccessor
 -pl helix-rest
   ```
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - This PR doesn't have backward compatibility issue.
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following 
wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their 
subject lines. In addition, my commits follow the guidelines from "[How to 
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to