junkaixue commented on code in PR #3010:
URL: https://github.com/apache/helix/pull/3010#discussion_r1999307701
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedInstanceCapacity.java:
##########
@@ -201,6 +201,12 @@ public synchronized boolean
checkAndReduceInstanceCapacity(String instance, Stri
return true;
}
+ if (!_instanceCapacityMap.containsKey(instance)) {
+ LOG.error("Instance: " + instance + " not found in instance capacity
map. Cluster may be using previous "
+ + "idealState that includes an instance that is no longer part of
the cluster.");
+ return false;
+ }
+
Review Comment:
The interesting thing is that shall we skip this instance and continue or
fail the entire pipeline using prev compute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
