junkaixue commented on code in PR #3010:
URL: https://github.com/apache/helix/pull/3010#discussion_r2031947175
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedInstanceCapacity.java:
##########
@@ -201,6 +201,12 @@ public synchronized boolean
checkAndReduceInstanceCapacity(String instance, Stri
return true;
}
+ if (!_instanceCapacityMap.containsKey(instance)) {
+ LOG.error("Instance: " + instance + " not found in instance capacity
map. Cluster may be using previous "
+ + "idealState that includes an instance that is no longer part of
the cluster.");
+ return false;
+ }
+
Review Comment:
simply ignore it in main logic can cause miscomputation on placement for
full / partial rebalance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
