GrantPSpencer opened a new pull request, #3019:
URL: https://github.com/apache/helix/pull/3019
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
N/A
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Stoppable check will fail if node has replica in bad state for partition
that does not have healthy siblings.
Example: (replicas = 3, min_active = 2)
Partition 0 : {
Node A : ERROR,
Node B: ERROR,
Node C: ERROR
}
Stoppable will fail on Node A because min active replica check will fail for
partition 0 since there are not 2 healthy replicas for this partition. However,
stopping this node will not affect the availability of this partition.
Therefore, we should skip the min active replica sibling check if the instance
replica is already in an unhealthy state. We should only fail for this check if
removing this instance will affect the availability of the partition (aka the
instance's replica is in a healthy state)
This PR also contains 2 unrelated changes:
1. Removing unused imports in TestWagedNPE
2. Changing ParticipantDeregistrationStage from using the configAccessor
(reads from ZK) to using the cached clusterConfig
### Tests
- [x] The following tests are written for this issue:
TestSiblingNodesActiveReplicaCheckSuccessWithReplicaInErrorState in
TestInstanceValidationUtil
- The following is the result of the "mvn test" command on the appropriate
module:
(If CI test fails due to known issue, please specify the issue and test PR
locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous
assumptions for certain methods or API. They include:
N/A
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
