GrantPSpencer commented on PR #3019: URL: https://github.com/apache/helix/pull/3019#issuecomment-2819706287
Pull request approved by: @xyuanlu Commit message: Stoppable API will skip the min active replica check for a replica if that replica is already in an unhealthy state. This is because stopping the instance will not affect that partition's availability as the replica is already in an unhealthy state (offline/error). Previously, this would prevent a node with an error state replica from being stopped if min_active for that partition was not satisfied. With this change, we will not consider the sister replicas and drop anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
