xyuanlu commented on PR #3023: URL: https://github.com/apache/helix/pull/3023#issuecomment-2821943484
Thanks for contributing to open source! I had a discussion with @MarkGaox, we feel like 1. Lets keep the behavior of IsEvacuateFinished the same, witch only check full-auto resources 2. Having the new API isInstanceDrained check all resources, including full-auto, semi-auto and customized. (not only aull-auto and customized) 3. in customized rebalancer, lets rename the param `isInstanceEvacuate` to sth like `isInstanceAssignableForCustomized` and include Liveinstance with Evacuate tag. Currently it includes online and offline instances, we only want online instances. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
