junkaixue commented on code in PR #3023:
URL: https://github.com/apache/helix/pull/3023#discussion_r2085603528
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java:
##########
@@ -132,10 +134,14 @@ private Map<String, String>
computeCustomizedBestStateForPartition(
boolean notInErrorState = currentStateMap != null
&&
!HelixDefinedState.ERROR.toString().equals(currentStateMap.get(instance));
boolean enabled = !disabledInstancesForPartition.contains(instance) &&
isResourceEnabled;
-
+ InstanceConfig instanceConfig =
cache.getInstanceConfigMap().get(instance);
+ boolean hasEvacuatedOp = instanceConfig != null &&
+ instanceConfig.getInstanceOperation().getOperation() ==
InstanceConstants.InstanceOperation.EVACUATE;
+ boolean isAssignableForCustomizedResource =
cache.getLiveInstances().containsKey(instance) && hasEvacuatedOp;
Review Comment:
Can we leave custom rebalancer away with this logic currently? I think this
requires a comprehensive design with custom rebalance users in open source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
