junkaixue commented on code in PR #3038:
URL: https://github.com/apache/helix/pull/3038#discussion_r2105462679
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkServer.java:
##########
@@ -150,4 +150,13 @@ public void shutdown() {
public ZkClient getZkClient() {
return _zkClient;
}
+
+ /**
+ * Get the ZooKeeper server instance.
+ * @return The ZooKeeper server instance
+ */
+ public ZooKeeperServer getZooKeeperServer() {
+ return _zk;
+ }
Review Comment:
Are you using Helix style to format it? It looked wired. For the place you
touched, we should fix it. Maybe it was not handled before.
##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java:
##########
@@ -115,6 +134,36 @@ private void setupZooKeepers() {
for (int i = 0; i < _numZk; i++) {
String zkAddress = ZK_PREFIX + (ZK_START_PORT + i);
_zkServerMap.computeIfAbsent(zkAddress, ZkTestBase::startZkServer);
+
_zkServerContainerManagerMap.computeIfAbsent(_zkServerMap.get(zkAddress),
ZkTestBase::createContainerManager);
+ }
+ }
+
+ /**
+ * Creates a ContainerManager with custom elapsed time functionality for a
ZkServer
+ */
+ private static ContainerManager createContainerManager(ZkServer zkServer) {
Review Comment:
This function has been repeated. Better make it as Util or in base class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
