LZD-PratyushBhatt commented on code in PR #3038:
URL: https://github.com/apache/helix/pull/3038#discussion_r2105528762
##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java:
##########
@@ -115,6 +134,36 @@ private void setupZooKeepers() {
for (int i = 0; i < _numZk; i++) {
String zkAddress = ZK_PREFIX + (ZK_START_PORT + i);
_zkServerMap.computeIfAbsent(zkAddress, ZkTestBase::startZkServer);
+
_zkServerContainerManagerMap.computeIfAbsent(_zkServerMap.get(zkAddress),
ZkTestBase::createContainerManager);
+ }
+ }
+
+ /**
+ * Creates a ContainerManager with custom elapsed time functionality for a
ZkServer
+ */
+ private static ContainerManager createContainerManager(ZkServer zkServer) {
Review Comment:
One is in helix-core module and other is in zookeeper-api. And in
zookeeper-api I dont see any packaging of test classes being done. So if we
make this common then we will need to modify pom.xml in some places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
