Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 )
Change subject: IMPALA-5936: operator '%' overflows on large decimals ...................................................................... Patch Set 1: (2 comments) Thanks! http://gerrit.cloudera.org:8080/#/c/8574/1/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/8574/1/be/src/exprs/decimal-operators-ir.cc@723 PS1, Line 723: int size = ::max(::max(x_size, y_size), return_size); \ > Can you add a brief comment to explain why max() is required? E.g. "An inpu I added a comment why max is needed, but didn't mention the mod operator, because it is inside a macro for other operators as well. http://gerrit.cloudera.org:8080/#/c/8574/1/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test File testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test: http://gerrit.cloudera.org:8080/#/c/8574/1/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test@301 PS1, Line 301: ---- QUERY > Can you add the JIRA number here? Sometimes it's useful to see where the te Done -- To view, visit http://gerrit.cloudera.org:8080/8574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b06c8acd5aa490943e84013faf2eaac7c26ceb4 Gerrit-Change-Number: 8574 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Nov 2017 17:45:06 +0000 Gerrit-HasComments: Yes
