Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 )
Change subject: IMPALA-5936: operator '%' overflows on large decimals ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8574/2/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/8574/2/be/src/exprs/decimal-operators-ir.cc@675 PS2, Line 675: case 4: { \ It's probably a good idea to DCHECK here that x_size <= 4 and y_size <= 4 http://gerrit.cloudera.org:8080/#/c/8574/2/be/src/exprs/decimal-operators-ir.cc@684 PS2, Line 684: Decimal8Value x_val = GetDecimal8Value(x, x_size, &overflow); \ Maybe DCHECK that x_size <= 8 and y_size <= 8, to make sure where are not running into the same issue here. -- To view, visit http://gerrit.cloudera.org:8080/8574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b06c8acd5aa490943e84013faf2eaac7c26ceb4 Gerrit-Change-Number: 8574 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:56:26 +0000 Gerrit-HasComments: Yes
