Hello Michael Brown, Philip Zeyliger, David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8580
to look at the new patch set (#2).
Change subject: IMPALA-6206: Fix data load failure with -notests
......................................................................
IMPALA-6206: Fix data load failure with -notests
When tests are not built, specifically with -notests, instead of
just -skiptests, the be-test target is omitted by cmake, and since
nothing in impalad depends on uda/udf samples, they are not built.
This causes data load to fail on a clean build.
Just build them anyway under the target ImpalaUdf since they
build in a few seconds.
This shaves a few minutes off data load testing by avoiding
the time spent linking tests. Note: only emperically, not
scientifically measured.
Testing: Verified that with this patch on a clean build,
libudasample.so and libudfsample.so get built, and without
it, also on a clean build, they do not. YMMV on -noclean
builds or with other test targets.
Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb
---
M be/src/udf_samples/CMakeLists.txt
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/8580/2
--
To view, visit http://gerrit.cloudera.org:8080/8580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb
Gerrit-Change-Number: 8580
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
