Hello Lars Volker, Michael Brown, Philip Zeyliger, David Knupp, Tim Armstrong,
Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8580
to look at the new patch set (#4).
Change subject: IMPALA-6206: Fix data load failure with -notests
......................................................................
IMPALA-6206: Fix data load failure with -notests
When tests are not built, specifically with -notests, instead of
just -skiptests, the be-test target is omitted by cmake, and since
nothing in impalad depends on uda/udf samples, they are not built.
This causes data load to fail on a clean build.
Just build them anyway under the target ImpalaUdf since they
build in a few seconds.
This shaves a few minutes off data load testing by avoiding
the time spent linking tests. Note: only empirically, not
scientifically measured.
Testing: Run a clean build
find . -name 'libud[af]sample.so'
./be/build/debug/udf_samples/libudasample.so
./be/build/debug/udf_samples/libudfsample.so
Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb
---
M bin/make_impala.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/8580/4
--
To view, visit http://gerrit.cloudera.org:8080/8580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb
Gerrit-Change-Number: 8580
Gerrit-PatchSet: 4
Gerrit-Owner: Zach Amsden <zams...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com>
