Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 )
Change subject: IMPALA-4927: Impala should be able to handle invalid input from Sentry ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8588/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8588/1//COMMIT_MSG@10 PS1, Line 10: non existent role Can you clarify what a "non existent role" is? http://gerrit.cloudera.org:8080/#/c/8588/1//COMMIT_MSG@20 PS1, Line 20: the code was instrumented to have a invalid Role " " and see how the condition nit: line overflow. http://gerrit.cloudera.org:8080/#/c/8588/1/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/8588/1/fe/src/main/java/org/apache/impala/util/SentryProxy.java@140 PS1, Line 140: // deleted from this set and we are left with the set of privileges that need nit: line overflow http://gerrit.cloudera.org:8080/#/c/8588/1/fe/src/main/java/org/apache/impala/util/SentryProxy.java@142 PS1, Line 142: Set<String> privilegesToRemove = role.getPrivilegeNames(); Just for my understanding, which exact line is throwing the exception where when rolename is empty? The jira doesn't include a stack trace. http://gerrit.cloudera.org:8080/#/c/8588/1/fe/src/main/java/org/apache/impala/util/SentryProxy.java@169 PS1, Line 169: role.getName() Can sentry ever return a null role name? -- To view, visit http://gerrit.cloudera.org:8080/8588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I781411018d580854d80a9cad81a1ded7ca16af8b Gerrit-Change-Number: 8588 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Comment-Date: Sat, 18 Nov 2017 20:43:26 +0000 Gerrit-HasComments: Yes
