Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 )
Change subject: IMPALA-4927: Impala should handle invalid input from Sentry ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8588/5/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/8588/5/fe/src/main/java/org/apache/impala/util/SentryProxy.java@144 PS5, Line 144: sentryPrivlist = : sentryPolicyService_.listRolePrivileges(processUser_, role.getName()); indentation is off http://gerrit.cloudera.org:8080/#/c/8588/5/fe/src/main/java/org/apache/impala/util/SentryProxy.java@146 PS5, Line 146: AuthorizationException An AuthorizationException is thrown when the sentry client throws a SentryAccessDeniedException. In all other cases, listRolePrivileges throws an InternalException. Are you certain that this try/catch will correctly handle all the error cases? -- To view, visit http://gerrit.cloudera.org:8080/8588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I781411018d580854d80a9cad81a1ded7ca16af8b Gerrit-Change-Number: 8588 Gerrit-PatchSet: 5 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 18:08:51 +0000 Gerrit-HasComments: Yes
