Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8588 )
Change subject: IMPALA-4927: Impala should handle invalid input from Sentry ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8588/5/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/8588/5/fe/src/main/java/org/apache/impala/util/SentryProxy.java@146 PS5, Line 146: AuthorizationException > While I agree that catching a generic Exception is a bad practice, my point I feel we should catch the specific set of exceptions documented for the API (exposed in their throws specification) that we actually want to do something with (in this case AuthorizationException), and bail completely if unknown exceptions arise (IOException, Timeout, etc...) because if that happens we don't fully understand how to continue the operation. In that case, the safest thing to do is abort, which is done easily enough by just not catching the generic Exception. -- To view, visit http://gerrit.cloudera.org:8080/8588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I781411018d580854d80a9cad81a1ded7ca16af8b Gerrit-Change-Number: 8588 Gerrit-PatchSet: 5 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:40:18 +0000 Gerrit-HasComments: Yes