Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 )
Change subject: IMPALA-4132: Use -fno-omit-frame-pointer ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8612/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/8612/1/be/CMakeLists.txt@42 PS1, Line 42: # -fno-omit-frame-pointers: Keep frame pointer for functions in register > Have you considered using -fasynchronous-unwind-tables instead? This page r >From my side no such consideration was made. Tim, are you aware of any discussion related to the flag Lars mentions? http://gerrit.cloudera.org:8080/#/c/8612/1/be/CMakeLists.txt@42 PS1, Line 42: # -fno-omit-frame-pointers: Keep frame pointer for functions in register : SET(CXX_COMMON_FL > How did this affect the size of the resulting binaries? Done Binary sizes (output of ls, in bytes): impalad: -fno-omit-frame-pointers: 437163424 -fomit-frame-pointers: 437110928 size of the whole be/build/debug/ dir: (output of du, in kbytes) -fno-omit-frame-pointers: 45456600 -fomit-frame-pointers: 45451244 -- To view, visit http://gerrit.cloudera.org:8080/8612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d0d88ba015a847356ed0274fe91017b98cb941 Gerrit-Change-Number: 8612 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2017 22:45:17 +0000 Gerrit-HasComments: Yes
