Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8639 )
Change subject: IMPALA-4664: Unexpected string conversion in Shell ...................................................................... Patch Set 1: shell/ext-py/sqlparse-0.1.14 includes only one fix for escaping backslashes. The fix was delivered to upstream by this change: https://github.com/andialbrecht/sqlparse/commit/e75e35869473832a1eb67772b1adfee2db11b85a Therefore, we don't have to keep this library on our repository. The version 0.1.14 is too old which was released in Nov 30, 2014. I would recommend to use recent and stable version 0.2.4. The old version has bugs for parsing such as following cases: * Variable assignment. The problem is that the tokens '=' '5' disappear. (e.g. set mt_dop=5;) * A series of queires in a single row. (e.g. select'DIG';select'DIG';) Please see the changelog of sqlparse: https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG -- To view, visit http://gerrit.cloudera.org:8080/8639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba6fa4e9ac570d22135ba51b844db8f9be965ca3 Gerrit-Change-Number: 8639 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Thu, 23 Nov 2017 16:48:41 +0000 Gerrit-HasComments: No
