Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8639 )
Change subject: IMPALA-4664: Unexpected string conversion in Shell ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8639/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8639/2//COMMIT_MSG@18 PS2, Line 18: Using sqlparse library in infra instead of It looks like this has a side-effect of not packaging sql-parse with the shell tarball. Unfortunately we don't have tests for the shell tarball artifact, but I think this will break it. See make_shell_tarball.sh -- To view, visit http://gerrit.cloudera.org:8080/8639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba6fa4e9ac570d22135ba51b844db8f9be965ca3 Gerrit-Change-Number: 8639 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2017 18:12:40 +0000 Gerrit-HasComments: Yes
