Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8654 )
Change subject: [DOCS] include version when building ...................................................................... Patch Set 1: > In general, I would like to keep a checked-in version of > impala_keydefs.ditamap so that there was always a way to do a > single 'dita ...' command to run a build for basic proofreading, > even if the production-ready technique went through extra steps. If this is the case, I'll have to think about this, then. You typically want to keep files under source control separate from artifacts generated by a build process. When you modify files under source control in-place, the modifications can leak into commits. In this case, you'd have to make sure the "version marker" never gets modified by a human who ran "make" locally. -- To view, visit http://gerrit.cloudera.org:8080/8654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2036993636c8f73c07790bd4bdf4da0b721549a Gerrit-Change-Number: 8654 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Laurel Hale <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2017 16:24:54 +0000 Gerrit-HasComments: No
