Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8654 )
Change subject: [DOCS] include version when building ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8654/1/docs/Makefile File docs/Makefile: http://gerrit.cloudera.org:8080/#/c/8654/1/docs/Makefile@31 PS1, Line 31: set -eu -o pipefail ;\ : export IMPALA_VERSION=$$(grep VERSION: version.info \ : | awk '{print $$2}' | sed -e 's/-SNAPSHOT//') ;\ : sed -e "s/\$$IMPALA_VERSION/$$IMPALA_VERSION/" < $< > $@ > Maybe make this a separate script file that can be run and tested outside o Sure. I'll fix it if we decide to move forward here. -- To view, visit http://gerrit.cloudera.org:8080/8654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2036993636c8f73c07790bd4bdf4da0b721549a Gerrit-Change-Number: 8654 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Laurel Hale <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2017 17:53:12 +0000 Gerrit-HasComments: Yes
