Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 )
Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners ...................................................................... Patch Set 1: (2 comments) Thanks for the review, your suggestion lead to a better solution indeed. http://gerrit.cloudera.org:8080/#/c/8684/1/be/src/exec/base-sequence-scanner.cc File be/src/exec/base-sequence-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8684/1/be/src/exec/base-sequence-scanner.cc@174 PS1, Line 174: if (!scan_node_->PartitionPassesFilters(context_->partition_descriptor()->id(), > This is a bit inconsistent with the other file types because it checks once Yeah, it also worried me a bit, I removed the filtering from here. http://gerrit.cloudera.org:8080/#/c/8684/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/8684/1/be/src/exec/hdfs-scan-node.cc@a497 PS1, Line 497: : > After looking at the code I'm wondering if this idea would lead to a more e Currently I added the header checking functionality to BaseSequenceScanner, other than that I think I've implemented this idea more or less. It shouldn't be too hard to extend ScanRangeMetadata with an is_header_range field, but would require more code modifications. Should I do that as well? -- To view, visit http://gerrit.cloudera.org:8080/8684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b38c26bcbe67f83efcc65a1723d766626ae3d3e Gerrit-Change-Number: 8684 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 01 Dec 2017 13:56:54 +0000 Gerrit-HasComments: Yes
