Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 )
Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8684/3/be/src/exec/base-sequence-scanner.cc File be/src/exec/base-sequence-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8684/3/be/src/exec/base-sequence-scanner.cc@56 PS3, Line 56: ScanRangeMetadata* header_metadata = new ScanRangeMetadata(*metadata); We need to add this to an ObjectPool so it's freed when the query is torn down (see what is done for the other place where these are allocated). -- To view, visit http://gerrit.cloudera.org:8080/8684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b38c26bcbe67f83efcc65a1723d766626ae3d3e Gerrit-Change-Number: 8684 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 04 Dec 2017 19:28:59 +0000 Gerrit-HasComments: Yes
