Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8781
Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation ...................................................................... IMPALA-6222: Add details to error msg on failure to get min reservation This patch adds the following details to the error message encountered on failure to get minimum memory reservation: - which ReservationTracker or MemTracker hit its limit - top 5 admitted queries that are consuming the most memory under the tracker that hit its limit Testing: - added tests to reservation-tracker-test.cc that verify the error message returned for different cases. - tested "initial reservation failed" condition manually to verify the error message returned (Request suggestion for an automated test). Change-Id: Ic4675fe923b33fdc4ddefd1872e6d6b803993d74 --- M be/src/runtime/bufferpool/reservation-tracker-test.cc M be/src/runtime/bufferpool/reservation-tracker.cc M be/src/runtime/bufferpool/reservation-tracker.h M be/src/runtime/initial-reservations.cc M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h M common/thrift/generate_error_codes.py 7 files changed, 169 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/8781/1 -- To view, visit http://gerrit.cloudera.org:8080/8781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4675fe923b33fdc4ddefd1872e6d6b803993d74 Gerrit-Change-Number: 8781 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]>
